Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] docs: kubernetes compatibility board #2696

Closed
wants to merge 1 commit into from
Closed

[WIP] docs: kubernetes compatibility board #2696

wants to merge 1 commit into from

Conversation

zhuangqh
Copy link
Contributor

@zhuangqh zhuangqh commented Jan 27, 2019 •
edited
Loading

Signed-off-by: zhuangqh zhuangqhc@gmail.com

Ⅰ. Describe what this PR did

Create a board to illustrate the compatibility against kubernetes.

Ⅱ. Does this pull request fix one issue?

fixes #2590

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Running the compatibility test with the aid of travis CI.

@codecov
Copy link

codecov bot commented Jan 27, 2019 •
edited
Loading

Codecov Report

Merging #2696 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2696   +/-   ##
=======================================
  Coverage   68.02%   68.02%           
=======================================
  Files         278      278           
  Lines       17392    17392           
=======================================
  Hits        11831    11831           
  Misses       4207     4207           
  Partials     1354     1354
Flag Coverage Δ
#criv1alpha2_test 39.34% <ø> (ø) ⬆️
#integration_test_0 36.23% <ø> (ø) ⬆️
#integration_test_1 35.14% <ø> (-0.03%) ⬇️
#integration_test_2 36.3% <ø> (+0.01%) ⬆️
#integration_test_3 35.16% <ø> (ø) ⬆️
#unittest 27.36% <ø> (ø) ⬆️

@zhuangqh
docs: kubernetes compatibility board
b83fe54 
Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
@starnop
Copy link
Contributor

starnop commented Jan 30, 2019 

Detected go version: go version go1.10.4 linux/amd64.
Kubernetes requires go1.11.1 or greater.
Please install go1.11.1 or later.]

It seems that we are not ready for Kubernetes 1.13. Maybe we can test it locally. 😄

@weekly-digest weekly-digest bot mentioned this pull request Feb 3, 2019
Closed
@zhuangqh
Copy link
Contributor Author

zhuangqh commented Feb 6, 2019 

Detected go version: go version go1.10.4 linux/amd64.
Kubernetes requires go1.11.1 or greater.
Please install go1.11.1 or later.]

It seems that we are not ready for Kubernetes 1.13. Maybe we can test it locally. 😄

Thanks for pointing out. I will test it after we upgrade to go1.11

@weekly-digest weekly-digest bot mentioned this pull request Feb 10, 2019
Closed
@zhuangqh
Copy link
Contributor Author

  • upgrade to go 1.11+

@weekly-digest weekly-digest bot mentioned this pull request May 19, 2019
Closed
@pouchrobot
Copy link
Collaborator

ping @zhuangqh
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

@zhuangqh
Copy link
Contributor Author

zhuangqh commented Jun 3, 2019

if we support the kubernetes 1.14, I will reopen

@zhuangqh zhuangqh closed this Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
areas/docs areas/orchestration conflict/needs-rebase size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature request] support more kubernetes version e2e test
3 participants
@zhuangqh @starnop @pouchrobot